Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove update method from platform #596

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove update method from platform #596

merged 1 commit into from
Sep 26, 2023

Conversation

andrea-pasquale
Copy link
Contributor

The platform.update method will not be necessary anymore in qibolab.
The update will performed directly inside qibocal qiboteam/qibocal#526

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/qibolab/platform.py ø

📢 Thoughts on this report? Let us know!.

@andrea-pasquale andrea-pasquale mentioned this pull request Sep 26, 2023
Merged
4 tasks
stavros11
stavros11 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there will be conflicts with #581 either way, so if you prefer feel free to merge this first.

@stavros11 stavros11 added this to the Qibolab 0.1.2 milestone Sep 26, 2023
@andrea-pasquale andrea-pasquale linked an issue Sep 26, 2023 that may be closed by this pull request
Improve update method for AbstractPlatform #418
Closed
@andrea-pasquale
Copy link
Contributor Author

I think there will be conflicts with #581 either way, so if you prefer feel free to merge this first.

Ok, let's merge now. Thanks for the feedback.

@andrea-pasquale andrea-pasquale merged commit 84b5943 into main Sep 26, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the remove_update branch November 9, 2023 10:45
@andrea-pasquale andrea-pasquale mentioned this pull request Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecandido alecandido alecandido approved these changes

@stavros11 stavros11 stavros11 approved these changes

Assignees

@andrea-pasquale andrea-pasquale

Labels
None yet
Projects
None yet
Milestone
Qibolab 0.1.2
Development

Successfully merging this pull request may close these issues.

Improve update method for AbstractPlatform
3 participants
@andrea-pasquale @alecandido @stavros11