Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign of pulse parameters is not deserialized properly #826

Closed
stavros11 opened this issue Mar 1, 2024 · 1 comment · Fixed by #869
Closed

Sign of pulse parameters is not deserialized properly #826

stavros11 opened this issue Mar 1, 2024 · 1 comment · Fixed by #869
Labels
bug Something isn't working
Milestone

Comments

@stavros11
Copy link
Member

pulse = Pulse(0, 40, 0.3, int(4e9), 0.0, shape="Drag(5, -0.02)")
print(pulse)

gives

Pulse(0, 40, 0.3, 4_000_000_000, 0, Drag(5, 0.02), None, PulseType.DRIVE, 0)

so -0.02 is converted to 0.02. I am not sure if this has any practical consequence in this case.

I found this while working on #789 for 0.2, but then I realized that it also exists for 0.1. I am guessing it will be solved by #818 where the ugly eval will be dropped, so I would even postpone for 0.2. @alecandido if you agree, we can put this directly to the 0.2 milestone.

@stavros11 stavros11 added the bug Something isn't working label Mar 1, 2024
@alecandido alecandido added this to the Qibolab 0.2.0 milestone Mar 1, 2024
@alecandido
Copy link
Member

I agreed and added to the milestone.

And indeed, by avoiding parsing the strings manually, these errors should become almost impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants