Drop start() and stop() in each qblox module

[PiergiorgioButtarini]

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.

[alecandido]

Now that #739 it would be useful to merge even this one.

Thanks @PiergiorgioButtarini for the PR!

[alecandido]

Actually: I approved the PR just looking at the files changed (with seems alright), but there is some doctest failing (not sure why, since they are untouched and failing for reasons which do not seem strictly connected to this PR...)

Maybe just merge/rebase on main.

[stavros11]

Doctest will be fixed by merging main here. There’s just a conflict to be addressed.

[codecov]

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (47d1d55) 62.68% compared to head (02a7a90) 62.71%.
Report is 23 commits behind head on main.

Files	Patch %	Lines
src/qibolab/instruments/qblox/cluster_qrm_rf.py	10.00%	9 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_bb.py	20.00%	4 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_rf.py	33.33%	4 Missing ⚠️
src/qibolab/instruments/qblox/controller.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   62.68%   62.71%   +0.03%     
==========================================
  Files          47       47              
  Lines        5930     5919      -11     
==========================================
- Hits         3717     3712       -5     
+ Misses       2213     2207       -6     

Flag	Coverage Δ
unittests	62.71% <16.66%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stavros11]

@PiergiorgioButtarini thanks for the update. Could you also check the qpu tests before merging? There are some tests that are still calling module.start()/module.stop() which should probably be removed, but there is also a more crucial error

AttributeError: 'NoneType' object has no attribute 'get_sequencer_state'

This error also appears when calling instrument.disconnect() for qblox outside of tests (I tried running a qibocal routine and got the same error after execution finished).

[PiergiorgioButtarini]

@stavros11 now this PR should be ready to be merged. I removed the useless tests and fixed the error you spotted.

[stavros11]

Thanks @PiergiorgioButtarini, it is fixed now.