-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace YAML runcard with JSON ones #782
Conversation
64b1535
to
bf79fd8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kernel #782 +/- ##
=======================================
Coverage 63.81% 63.81%
=======================================
Files 48 48
Lines 5771 5771
=======================================
Hits 3683 3683
Misses 2088 2088
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bf79fd8
to
98f748e
Compare
98f748e
to
06faa29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would just ask @scarrazza if he agrees with the change, because historically we were using json and he proposed moving to yaml (I am guessing for readability?).
It is fine by me, supposing json will reduce complexity in terms of dependencies. |
@andrea-pasquale @alecandido I spoke with @aorgazf and he also agrees with this change, so if this is ready we can merge and I will propagate the changes to qibolab_platforms_qrc. |
Good, @stavros11 I might have the majority of the JSON ready for |
@stavros11 now it is merged. It will be anyhow in the next release, so no need to rush for the changes in the |
Thanks, if you already have them feel free to open a PR. Otherwise I will do it later or tomorrow.
I am not sure if there is anyone (other than qibocal CI) that is using releases, but in any case it will be useful to have at least a PR with the json runcards to be able to keep developing on qibolab main. |
I believe Qibocal should usually develop against releases, and only sometimes using the Git version (when a new Qibolab feature is strictly required). |
Indeed with the current workflow Qibocal is only working with releases. |
I know, this is the unpleasant part, and the motivation for monorepos. However, hopefully it will happen less and less :) |
Closes #762