Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace YAML runcard with JSON ones #782

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Replace YAML runcard with JSON ones #782

merged 3 commits into from
Jan 29, 2024

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Jan 25, 2024

Closes #762

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d869de0) 63.81% compared to head (2b96468) 63.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           kernel     #782   +/-   ##
=======================================
  Coverage   63.81%   63.81%           
=======================================
  Files          48       48           
  Lines        5771     5771           
=======================================
  Hits         3683     3683           
  Misses       2088     2088           
Flag Coverage Δ
unittests 63.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alecandido added a commit that referenced this pull request Jan 25, 2024
alecandido added a commit that referenced this pull request Jan 25, 2024
@andrea-pasquale andrea-pasquale mentioned this pull request Jan 25, 2024
4 tasks
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would just ask @scarrazza if he agrees with the change, because historically we were using json and he proposed moving to yaml (I am guessing for readability?).

@scarrazza
Copy link
Member

It is fine by me, supposing json will reduce complexity in terms of dependencies.

Base automatically changed from kernel to main January 26, 2024 13:43
@stavros11
Copy link
Member

@andrea-pasquale @alecandido I spoke with @aorgazf and he also agrees with this change, so if this is ready we can merge and I will propagate the changes to qibolab_platforms_qrc.

@alecandido alecandido merged commit 154aab0 into main Jan 29, 2024
24 checks passed
@alecandido alecandido deleted the yaml-to-json branch January 29, 2024 11:51
@andrea-pasquale
Copy link
Contributor

@andrea-pasquale @alecandido I spoke with @aorgazf and he also agrees with this change, so if this is ready we can merge and I will propagate the changes to qibolab_platforms_qrc.

Good, @stavros11 I might have the majority of the JSON ready for qibolab_platform_qrc. I can take of that if you want.

@alecandido
Copy link
Member Author

@stavros11 now it is merged. It will be anyhow in the next release, so no need to rush for the changes in the qibolab_platforms_qrc (for as long as people will use the latest release, of course it will be required for testing new PRs in Qibolab)

@stavros11
Copy link
Member

Good, @stavros11 I might have the majority of the JSON ready for qibolab_platform_qrc. I can take of that if you want.

Thanks, if you already have them feel free to open a PR. Otherwise I will do it later or tomorrow.

@stavros11 now it is merged. It will be anyhow in the next release, so no need to rush for the changes in the qibolab_platforms_qrc (for as long as people will use the latest release, of course it will be required for testing new PRs in Qibolab)

I am not sure if there is anyone (other than qibocal CI) that is using releases, but in any case it will be useful to have at least a PR with the json runcards to be able to keep developing on qibolab main.

@alecandido
Copy link
Member Author

I believe Qibocal should usually develop against releases, and only sometimes using the Git version (when a new Qibolab feature is strictly required).

@andrea-pasquale
Copy link
Contributor

Indeed with the current workflow Qibocal is only working with releases.
This is why usually I push for qibolab releases 😄

@alecandido
Copy link
Member Author

This is why usually I push for qibolab releases 😄

I know, this is the unpleasant part, and the motivation for monorepos. However, hopefully it will happen less and less :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop yaml dependency
4 participants