TWPA extra

[alecandido]

Closes #961

It was easier to do it immediately, instead of leaving a further issue open and forget.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.02%. Comparing base (1e3a501) to head (2bfcb53).

Additional details and impacted files

@@           Coverage Diff           @@
##              0.2     #962   +/-   ##
=======================================
  Coverage   42.02%   42.02%           
=======================================
  Files          74       74           
  Lines        5820     5820           
=======================================
  Hits         2446     2446           
  Misses       3374     3374           

Flag	Coverage Δ
unittests	42.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stavros11]

Okay, but I still don't see how this is any useful given that if someone knows how to do pip install .[twpa] they could just as well do pip install .[los]. The missing piece is documentation.

[alecandido]

Okay, but I still don't see how this is any useful given that if someone knows how to do pip install .[twpa] they could just as well do pip install .[los]. The missing piece is documentation.

Ah, yes, definitely.

This is not useful on its own, just "clearer". I.e., if you need a TWPA, but not an LO, then you could use pip install .[twpa], instead of pip install .[los], when you don't have LOs.

But the relevant one is certainly qiboteam/qibolab_platforms_qrc#163

[stavros11]

This is not useful on its own, just "clearer". I.e., if you need a TWPA, but not an LO, then you could use pip install .[twpa], instead of pip install .[los], when you don't have LOs.

Strictly speaking, qibolab is not controlling the TWPA itself but the TWPA pump, which in all cases so far it happens to actually be an LO. :) (no issues with merging this though, fortunately it is not causing any conflicts)

[alecandido]

Strictly speaking, qibolab is not controlling the TWPA itself but the TWPA pump, which in all cases so far it happens to actually be an LO. :) (no issues with merging this though, fortunately it is not causing any conflicts)

Ok, this is formally correct, but slightly less intuitive.

To be fair, both los and twpa are a bit out of the usual scheme. Indeed, we don't have extras for controller, so we may separate by vendor, and possibly specific product.

However, we are not really at the level of being that strict on this, and even los alone is not that bad. It was just confusing me.
But, if this is worse, we could even revert.