Temporary fixes to support pytorch backend migration #45
+112
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 11 11
Lines 488 488
=======================================
Hits 325 325
Misses 163 163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Are these just the recent modifications added in qiboteam/qibo#1450 ? |
Required for the backend migration. |
BrunoLiegiBastonLiegi
approved these changes
Nov 8, 2024
src/qiboml/backends/__init__.py
Outdated
Comment on lines
10
to
13
| AVAILABLE_PLATFORMS = [ | ||
| "tensorflow", | ||
| "pytorch", | ||
| ] # temporary: to remove once pytorch and tensorflow are migrated and jax is fully working |
There was a problem hiding this comment.
what's the plan here? now that we are migrating pytorch, we could get rid of this, right?
There was a problem hiding this comment.
I would keep it until Jax is ready, if we still plan to support Jax soon.
renatomello
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to complete the Pytorch backend migration from Qibo to Qiboml.