Feature/prettier eslint #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wwwenjie is attempting to deploy a commit to a Personal Account owned by @qier222 on Vercel. @qier222 first needs to authorize it. |
|
base on #395 |
Closed
|
Deploy preview for yesplaymusic ready! Built with commit f401e62 |
wwwenjie
commented
Mar 11, 2021
| @@ -12,7 +12,6 @@ import installExtension, { VUEJS_DEVTOOLS } from "electron-devtools-installer"; | |||
| import express from "express"; | |||
| import expressProxy from "express-http-proxy"; | |||
| import Store from "electron-store"; | |||
| import path from "path"; | |||
There was a problem hiding this comment.
lint said path is never used, not sure if background.js uses it.
Comment on lines
+46
to
+47
| "eslint-config-prettier": "^8.1.0", | ||
| "eslint-plugin-prettier": "^3.3.1", |
There was a problem hiding this comment.
move to dev dependencies
llovvoll
pushed a commit
to llovvoll/YesPlayMusic
that referenced
this pull request
Mar 11, 2021
* feat: add translations * refactor: use trinocular operators instead if * style: add prettier to eslint, fix lint errors * chore: add .gitattr
threo9
added a commit
to threo9/YesPlayMusic
that referenced
this pull request
Mar 11, 2021
chore: Feature/prettier eslint (qier222#397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think its better to add prettier to eslint and set prettier/prettier rule to error (this PR do), so we can get prettier error during code.
I notice that this project add husky to format style, but sadly husky v4 is not work with sourcetree and which causes the error style commit to this PR.