Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--citations should report plugin citations when called on an action #336

Closed
gregcaporaso opened this issue Apr 24, 2024 · 1 comment · Fixed by #339
Closed

--citations should report plugin citations when called on an action #336

gregcaporaso opened this issue Apr 24, 2024 · 1 comment · Fixed by #339
Labels
good first issue Good for newcomers

Comments

@gregcaporaso
Copy link
Member

gregcaporaso commented Apr 24, 2024

Forum x-ref

Current behavior:

$ qiime hello-metagenome --citations
% use `qiime tools citations` on a QIIME 2 result for complete list

@misc{key0,
 author = {Caporaso, J Gregory and Bolyen, Evan},
 howpublished = {https://develop.qiime2.org},
 title = {Developing with QIIME 2},
 year = {2024}
}

$ qiime hello-metagenome duplicate-table --citations
No citations found.

Desired behavior:
The action-level --citations report should include all of the citations from the plugin-level --citations report.

@Oddant1
Copy link
Member

Oddant1 commented Jun 27, 2024

@gregcaporaso I opened a PR that should close this and requested your review on it to make sure it's doing what you wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants