Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor replay namespaces #739

Merged
merged 10 commits into from
May 28, 2024
Merged

refactor replay namespaces #739

merged 10 commits into from
May 28, 2024

Conversation

colinvwood
Copy link
Contributor

No description provided.

@colinvwood colinvwood marked this pull request as draft January 5, 2024 00:14
@colinvwood colinvwood marked this pull request as ready for review January 5, 2024 22:23
@colinvwood colinvwood changed the title WIP: refactor replay namespaces refactor replay namespaces Jan 5, 2024
Oddant1
Oddant1 reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@Oddant1 Oddant1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial comments. I think it does look better overall

qiime2/core/archive/provenance_lib/replay.py Show resolved Hide resolved
qiime2/core/archive/provenance_lib/replay.py Outdated Show resolved Hide resolved
qiime2/core/archive/provenance_lib/replay.py Outdated Show resolved Hide resolved
ebolyen
ebolyen approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@ebolyen ebolyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm relying on the tests a bit here, but these changes look good.

It looks like creating the methods have made things a little bit easier to understand from the outside in, since I don't have to track the various dictionaries anymore.

Nice job!

@ebolyen ebolyen merged commit 59ec732 into qiime2:dev May 28, 2024
4 checks passed
@Oddant1 Oddant1 mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oddant1 Oddant1 Oddant1 left review comments

@ebolyen ebolyen ebolyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2024.5
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinvwood @ebolyen @Oddant1