Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add gitlab doc #324

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

proposal: add gitlab doc #324

wants to merge 13 commits into from

Conversation

never112
Copy link
Contributor

@never112 never112 commented Sep 4, 2024

No description provided.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 50fe79d
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/671642f690b2dc0008aff273

@never112 never112 changed the title add gitlab doc proposal: add gitlab doc Sep 4, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.13%. Comparing base (7ebb35b) to head (fec25ac).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   36.13%   36.13%           
=======================================
  Files          27       27           
  Lines        2081     2081           
=======================================
  Hits          752      752           
  Misses       1228     1228           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

qiniu-x bot commented Sep 19, 2024

[Git-flow] Hi @never112, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'qiniu:master' into doc3

    Merge branch 'doc3' of github.com:never112/reviewbot into doc3

  • Following commits have duplicated messages

    add gitlab doc

    add gitlab doc

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@@ -264,7 +274,7 @@ func (s *Server) handle(ctx context.Context, event *github.PullRequestEvent) err
if err != nil {
return fmt.Errorf("failed to prepare repo dir: %w", err)
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change
r, err := s.gitClientFactory.ClientForWithRepoOpts(org, repo, gitv2.RepoOpts{

If you have any questions about this comment, feel free to raise an issue here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants