Prepend certs instead of append #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement cert overlap multiple pub keys has to life at the cert bundle currectly this is implemented appending new certs but this is not ok from TLS perspective since the first public key or "leaf" has to match with the private key [1]. [1] https://github.com/golang/go/blob/master/src/crypto/tls/tls.go#L292-L294 Signed-off-by: Quique Llorente <[email protected]>
qinqon
added a commit
to qinqon/kubernetes-nmstate
that referenced
this pull request
Apr 28, 2021
Test qinqon/kube-admission-webhook#48 Signed-off-by: Quique Llorente <[email protected]>
qinqon
added a commit
to qinqon/kubemacpool
that referenced
this pull request
Apr 28, 2021
Test qinqon/kube-admission-webhook#48 Signed-off-by: Quique Llorente <[email protected]>
qinqon
added a commit
that referenced
this pull request
Apr 28, 2021
Priori v0.15.0 the cert overlap was implemented adding appending new certs but this is not correct [1], latest version of the kube-admission-webhook lib do a prepend to comply with TLS verification at golang web server, this introduce a problem at upgrades since it will take into account the cert at the end but it will not point to the last one. [1] #48 Signed-off-by: Quique Llorente <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement cert overlap multiple pub keys has to life at the cert
bundle currectly this is implemented appending new certs but this is not
ok from TLS perspective since the first public key or "leaf" has to
match with the private key [1].
[1] https://github.com/golang/go/blob/master/src/crypto/tls/tls.go#L292-L294
Test PR on kubernetes-nmstate nmstate/kubernetes-nmstate#734
Test PR on kubemacpool k8snetworkplumbingwg/kubemacpool#289
Signed-off-by: Quique Llorente [email protected]