certificate: Reconcile only created secrets #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamLavi
requested changes
Dec 1, 2021
If two cert-managers are running at a cluster they will each other secrets since the kube-admission-webhook annotation is there. This change filter the secrets and only reconcile the ones with the CA cert name from webhook config and the services owned by them. Signed-off-by: Quique Llorente <[email protected]>
qinqon
force-pushed
the
reconcile-only-created-secrets
branch
from
cc17695
to
fd7f2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two cert-managers are running at a cluster they will each other
secrets since the kube-admission-webhook annotation is there. This
change filter the secrets and only reconcile the ones with the CA cert
name from webhook config and the services owned by them.
Signed-off-by: Quique Llorente [email protected]