Use opflow operators in dynamics #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I will note that the current plan is to deprecate (next release) and later remove opflow from Terra Qiskit/qiskit#9176 |
Ah good to know, thanks. @donsano33 based on this I think I will actually prefer to not merge this. Apologies for that. Even though it will be convenient in the short term, I think it will be more inconvenient when we run into the eventual known incompatibility of an upcoming version of terra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support and type hints, so that qiskit.opflow operators inheriting from qiskit.opflow.OperatorBase can be used to construct a HamiltonianModel and a RotatingFrame.
Details and comments
It kind of gets messy with the type hints, not sure what to do about that.
Needs the "New Feature" Label, not sure if I can do this myself.