VQC fails to initialize from minimal settings #217
Assignees
Labels
Comments
|
mind if I take this? |
|
@jonvet Sure, I assigned it to you |
jonvet
pushed a commit
to jonvet/qiskit-machine-learning
that referenced
this issue
Oct 25, 2021
Fixes qiskit-community#217 where ```VQC``` couldn't be instantiated unless either ```feature_map``` or ```ansatz``` were provided. ```VQC``` is now instantiated with the default ```feature_map``` and/or ```ansatz```. Changelog: Bugfix
jonvet
pushed a commit
to jonvet/qiskit-machine-learning
that referenced
this issue
Oct 25, 2021
Fixes qiskit-community#217 where ```VQC``` couldn't be instantiated unless either ```feature_map``` or ```ansatz``` were provided. ```VQC``` is now instantiated with the default ```feature_map``` and/or ```ansatz```. Changelog: Bugfix
adekusar-drl
added a commit
that referenced
this issue
Nov 2, 2021
* Summary: Fixes #217 where ```VQC``` couldn't be instantiated unless either ```feature_map``` or ```ansatz``` were provided. ```VQC``` is now instantiated with the default ```feature_map``` and/or ```ansatz```. Changelog: Bugfix * Summary: Fixes #217 where ```VQC``` couldn't be instantiated unless either ```feature_map``` or ```ansatz``` were provided. ```VQC``` is now instantiated with the default ```feature_map``` and/or ```ansatz```. Changelog: Bugfix * add docstring to test * Update releasenotes/notes/fix-vqc-initialisation-bdf753c45b66f192.yaml Co-authored-by: Anton Dekusar <[email protected]> Co-authored-by: jonvet <[email protected]> Co-authored-by: Manoel Marques <[email protected]> Co-authored-by: Anton Dekusar <[email protected]>
gentinettagian
pushed a commit
to gentinettagian/qiskit-machine-learning
that referenced
this issue
Dec 14, 2021
* Summary: Fixes qiskit-community#217 where ```VQC``` couldn't be instantiated unless either ```feature_map``` or ```ansatz``` were provided. ```VQC``` is now instantiated with the default ```feature_map``` and/or ```ansatz```. Changelog: Bugfix * Summary: Fixes qiskit-community#217 where ```VQC``` couldn't be instantiated unless either ```feature_map``` or ```ansatz``` were provided. ```VQC``` is now instantiated with the default ```feature_map``` and/or ```ansatz```. Changelog: Bugfix * add docstring to test * Update releasenotes/notes/fix-vqc-initialisation-bdf753c45b66f192.yaml Co-authored-by: Anton Dekusar <[email protected]> Co-authored-by: jonvet <[email protected]> Co-authored-by: Manoel Marques <[email protected]> Co-authored-by: Anton Dekusar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This problem was brought up here https://qiskit.slack.com/archives/CB6C24TPB/p1631635618251500
The following should create a VQC instance with default feature map and ansatz.
however it fails with
It seems to be from this logic https://github.com/Qiskit/qiskit-machine-learning/blob/673140c0624ad928ec1b6da307e58221847c48da/qiskit_machine_learning/algorithms/classifiers/vqc.py#L106-L108
where the latter tries to compose
feature_mapandansatz, which are directly the params from init. I think more likely it should be usingself.feature_mapandself.ansatzto pull in whatever these ended up as, whether supplied or internally created.Needs some unit tests to cover the various paths whether defaulted or not.
The text was updated successfully, but these errors were encountered: