-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TrainableFidelityStatevectorKernel
#639
Add TrainableFidelityStatevectorKernel
#639
Conversation
Pull Request Test Coverage Report for Build 5144942540
💛 - Coveralls |
6d14324
to
4b1b144
Compare
767877a
to
b3d3ec6
Compare
releasenotes/notes/add-trainable-fidelity-statevector-kernel-6d9c927d16c1cb35.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-trainable-fidelity-statevector-kernel-6d9c927d16c1cb35.yaml
Outdated
Show resolved
Hide resolved
87d822a
to
040fd3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late review, I think that Steve already commented on all the key points, so LGTM. Maybe now that we are at it, we could also sneak in the fix for #649 in this PR?
94350c6
to
f24ad8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
f24ad8d
to
fd24b86
Compare
Pull Request Test Coverage Report for Build 5222812947
💛 - Coveralls |
* add trainable fidelity statevector kernel * fix copyright * refactor check on trainable parameters * fix copyright * consolidate trainable kernels tests * avoid string flags in tests * fix copyright * test trainer with statevector kernel * add release note * fix style * format release note * lint * style * Update release note based on Steve's comments * add imports to release note snippet * fix typo --------- Co-authored-by: Anton Dekusar <[email protected]>
Summary
Adds a
TrainableFidelityStatevectorKernel
class. Closes #638.Details and comments
For consistency with
TrainableFidelityQuantumKernel
, an equivalent class that inherits fromFidelityStatevectorKernel
andTrainableKernel
has been added.To avoid some code repetition,
_parameter_array
has been moved toTrainableKernel
and this now raises the error that was previously inevaluate
ofTrainableFidelityQuantumKernel
.TrainableFidelityStatevectorKernel
is now unit tested alongsideTrainableFidelityQuantumKernel
and also withQuantumKernelTrainer
.Performance
Output: