Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint after opflow deprecation #1135

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Apr 20, 2023

Summary

Qiskit/qiskit#9176 deprecated opflow, which included StarAlebraMixin used by SecondQuantizedOp. To add the deprecated decorator for the class an empty init() method was added in order to add a decorator.

The above then gave rise to this in the nightly scheduled builds here in Nature

************* Module qiskit_nature.operators.second_quantization.second_quantized_op
qiskit_nature/operators/second_quantization/second_quantized_op.py:39:19: E1121: Too many positional arguments for constructor call (too-many-function-args)

which I have simply supressed in the code. The code, like opflow, is deprecated and will be removed in the future,

Details and comments

@woodsp-ibm woodsp-ibm added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Apr 20, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4756373990

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 85.856%

Files with Coverage Reduction New Missed Lines %
qiskit_nature/drivers/second_quantization/psi4d/psi4driver.py 2 84.43%
Totals Coverage Status
Change from base Build 4736677004: -0.005%
Covered Lines: 18586
Relevant Lines: 21648

💛 - Coveralls

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrossinek mrossinek merged commit bc28e98 into qiskit-community:main Apr 20, 2023
mergify bot pushed a commit that referenced this pull request Apr 20, 2023
* Fix lint after opflow deprecation

* Copyright date

(cherry picked from commit bc28e98)
@woodsp-ibm woodsp-ibm deleted the ci_lint branch April 20, 2023 17:14
mergify bot added a commit that referenced this pull request Apr 20, 2023
* Fix lint after opflow deprecation

* Copyright date

(cherry picked from commit bc28e98)

Co-authored-by: Steve Wood <[email protected]>
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
* Fix lint after opflow deprecation

* Copyright date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants