Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot to manage Github Actions update #1318

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Jan 31, 2024

Summary

Build have started emitting warnings:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I recently fixed these manually in qiskit algorithms but then saw qiskit experiments setup dependabot to check and update the actions. Upon finding actions needing update it will create a PR for this. So this is a first step to setting that up and commits a config file for dependabot to use, once that's in place there are other settings to enable it etc that I will do so once this merged. It seems better to have this automated.

Details and comments

In doing this first on Qiskit Machine Learning it seems that dependabot will do a PR for each action it updates. This meant separate PRs for the change in version to the upload-artifact and download-artifact, This is seemed would cause a failure in each of the PRs that I surmise is due to the upload being done in one version and the download with another. The download would always fail saying file could not be found. In ML I fixed things by doing a manual PR that did both at the same time hence #1317.

I marked this OnHold since it would be better to merge this after #1317 is merged. And while I could have updated all the actions manually I figured not doing so would allow us to check dependabot is working ok for Nature here

@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7741308121

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 86.765%

Files with Coverage Reduction New Missed Lines %
qiskit_nature/second_q/drivers/psi4d/psi4driver.py 1 85.12%
Totals Coverage Status
Change from base Build 7741299066: 0.009%
Covered Lines: 8785
Relevant Lines: 10125

💛 - Coveralls

@woodsp-ibm woodsp-ibm removed the on hold Can not fix yet label Feb 1, 2024
@woodsp-ibm woodsp-ibm merged commit 222455a into qiskit-community:main Feb 1, 2024
15 checks passed
@woodsp-ibm woodsp-ibm deleted the add_dependabot branch February 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants