Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSV tutorial #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

orielkiss
Copy link

Error mitigation tutorial based on dual state verification. Outcome of Autumn 22 QAMP project #3.
(i tried to run the automatic tests using tox, and it seems some original code (such as dynamical decoupling) don't pass the tests),

@kevinsung
Copy link
Collaborator

Thanks for the pull request! I have updated the contributing guide to list our current criteria for considering submissions. Can you check that your submission fulfills the criteria?

@kevinsung
Copy link
Collaborator

Hi @orielkiss I think it makes to include this as a utility. It needs to be refactored though:

  • tutorial_DSV.ipynb and associated files should be moved to docs/dual_state_verification/.
  • dual_state_verification.py should be moved to qiskit_research/utils

As for the module code, a few initial comments:

  • Please add type annotations to the function arguments
  • Please make sure all publicly exposed functions and classes have docstrings that include documentation of the arguments. You can checkout the other code in utils/ for guidance.

@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants