Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting of skinparam with role is incorrect #102

Closed
SanderSmee opened this issue Feb 27, 2018 · 4 comments
Closed

Syntax highlighting of skinparam with role is incorrect #102

SanderSmee opened this issue Feb 27, 2018 · 4 comments

Comments

@SanderSmee
Copy link

See the accompanying image. Syntaxhighlighting is incorrect for skinparam if the correct plantuml markup item<<role>> is used for items with a role. If the incorrect markup item <<role>> is used, highlighting is presumably correct. Note the difference of the one space character between item and <<.

screen shot 2018-02-27 at 11 41 43

@SanderSmee
Copy link
Author

I think this can be resolved by removing the \s+ from the regexes for inline and block skinparam definitions.

I have no experience developing a vscode plugin, but am willing to try and provide a PR if you can't spend time on this issue.

qjebbs added a commit that referenced this issue Feb 28, 2018
qjebbs added a commit that referenced this issue Feb 28, 2018
@qjebbs
Copy link
Owner

qjebbs commented Feb 28, 2018

Yes, you're right. Thanks for feedback.

image

@SanderSmee
Copy link
Author

Thank you, a great improvement.
I noticed the last line in your example and expected it to be invalid plantuml, but it is accepted (and doesn't apply to the stereotype because of the space character).

@qjebbs
Copy link
Owner

qjebbs commented Feb 28, 2018

Yes, you are right. In last line, I intentionally made them so, to show how new syntax behaves: asdasd is the param, while the whole <<asd>> #red is the value.

@qjebbs qjebbs closed this as completed in c839cd7 Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants