Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not properly use proxy settings #169

Open
arnauldvm opened this issue Nov 9, 2018 · 7 comments
Open

Does not properly use proxy settings #169

arnauldvm opened this issue Nov 9, 2018 · 7 comments

Comments

@arnauldvm
Copy link

I found out that the extension is using the http_proxy environment variable,
even though there is an "http.proxy" setting defined in VS Code.

If, for some reason, I want VS Code to use a different proxy, it gives unexpected behavior for PlantUML.

@arnauldvm arnauldvm changed the title Does not properly use pxy settings Does not properly use proxy settings Nov 9, 2018
@qjebbs
Copy link
Owner

qjebbs commented Nov 12, 2018

Please update and help me test, does it works good:

  1. if you have http.proxy configured
  2. if you have environment variable configured (no http.proxy setting)

I cannot test because I don't have a http proxy. Thanks for the help.

@arnauldvm
Copy link
Author

arnauldvm commented Dec 6, 2018

  1. if I have http.proxy configured (and no environment variable): no
  2. yes

@zllvm
Copy link

zllvm commented Jun 5, 2019

I have also a problem with using this extension behind the proxy. When I try to include an external puml like this:
!includeurl https://raw.githubusercontent.com/awslabs/aws-icons-for-plantuml/master/dist/AWSCommon.puml
the following error appears:
image
Both http_proxy and https_proxy are set in as environment variables. Setting http.proxy option didn't help either.

@Thialala
Copy link

Thialala commented Jul 1, 2019

I fixed the same issue by setting the proxy settings using plantuml.commandArgs.

  • Open VS Code
  • Go to File => Preferences => Settings
  • In the search box, enter settings.json
  • Then click on "Edit settings.json"
  • Enter the following config:
"plantuml.commandArgs": [
       "-Dhttp.proxyHost=your-proxy.com,
       "-Dhttp.proxyPort=your-proxy-port",
       "-Dhttps.proxyHost=your-proxy.com",
       "-Dhttps.proxyPort=your-proxy-port"
   ]

@qjebbs
Copy link
Owner

qjebbs commented Jul 1, 2019

@Thialala, Thanks for the feedback.

@zllvm, @Thialala gives the right solution to your case.

@arnauldvm If yours is the same use case, http.proxy won't help, because it cannot control the behavior of java or plantuml.jar.

@arnauldvm
Copy link
Author

@arnauldvm If yours is the same use case, http.proxy won't help, because it cannot control the behavior of java or plantuml.jar.

I'll test this.

@StefH
Copy link

StefH commented Jul 10, 2024

@Thialala
Thanks for this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants