Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includesearch diagramsRoot does not work correct #209

Closed
anotherandi opened this issue Mar 25, 2019 · 1 comment
Closed

includesearch diagramsRoot does not work correct #209

anotherandi opened this issue Mar 25, 2019 · 1 comment

Comments

@anotherandi
Copy link

anotherandi commented Mar 25, 2019

Inclusion from included files does not work correct. Error message: "Cannot include [filename]"

When I include a file that contains macros an the macro include yet another file.
It looks like the includepath only works correct for the currently opened/edited plantuml file but not for included files. When I use !include in an included file I still have to use relative paths.

BTW: Generating the image works fine when I use the plantuml.jar and set the include.path to the same folder as diagramsRoot.

Having a common base directory for inclusion I basically consider a good idea. But I wood prefer to specify an include folder and still be able to use relative paths in a plantuml file. Similar to the way C/C++ behaves. First try in the folder of the current file and then proceed with the include paths.

@qjebbs
Copy link
Owner

qjebbs commented Mar 26, 2019

Thanks for the report, and the solution (-Dplantuml.include.path), the fix goes with next release.

About the C/C++ behaves, I'm afraid it's hard to do, because the plantuml.jar is an outside dependency, to this extension, that I cannot control it finely.

As I tested, suppose we have:

  • "plantuml.includeSearch": "DiagramsRoot",
  • A include chain: source -> include1 -> include2 -> include3

Then, wheninclude2 references include3, it works both with the relative path:

  • From include3 to include2,
  • From include3 to DiagramsRoot

Kind of like C/C++ behaves you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants