Generate Preview Images from plantuml.urlServer #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjebbs
reviewed
Apr 26, 2017
| if (config.previewFromUrlServer) { | ||
| task = httpExporter.exportToBuffer(diagram, previewFileType); | ||
| } else { | ||
| task = exporter.exportToBuffer(diagram, previewFileType); |
There was a problem hiding this comment.
In local export, this.process should be recorded for later processing of prevent from starting to many processes.
|
Awesome work! Thank you! PS: Generate from server doesn't work properly while diagrams got |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
we are running our own instance of a plantuml server and would like to be able to utilize image creation from it, instead of the local java process. It's quite a lot faster there and our users are not required to setup plantuml locally.
I extended the code accordingly and added an option plantuml.previewFromUrlServer that is "false" by default.
Let me know if you want me to further refine my solution.
I would be happy if the changes could be merged back to the main branch.