Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QOL-8943] look up package ID from resource ID #84

Merged
merged 3 commits into from
Jun 9, 2022
Merged

[QOL-8943] look up package ID from resource ID #84

merged 3 commits into from
Jun 9, 2022

Conversation

ThrawnCA
Copy link
Contributor

@ThrawnCA ThrawnCA commented Jun 9, 2022

  • Don't assume that the package ID will be supplied as part of the uploaded resource

@ThrawnCA
[QOL-8943] look up package ID from resource ID
b2f37e3 
- Don't assume that the package ID will be supplied as part of the uploaded resource
@ThrawnCA
[QOL-8943] use uploaded package ID as a fallback
5db6e38 
- New resources may not have an ID yet, so we just need to use the supplied values
duttonw
duttonw approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@duttonw duttonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you slip in a test, or raise a task to make up in the next 4 weeks.

@ThrawnCA ThrawnCA merged commit 79d2a28 into develop Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duttonw duttonw duttonw approved these changes

@asifaminb asifaminb Awaiting requested review from asifaminb

@chris-randall-qol chris-randall-qol Awaiting requested review from chris-randall-qol

@devonpis devonpis Awaiting requested review from devonpis

@kundupz kundupz Awaiting requested review from kundupz

@RossWebsterWork RossWebsterWork Awaiting requested review from RossWebsterWork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThrawnCA @duttonw