Cicd upgrades #99
Merged
Cicd upgrades #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add qld-qov ckan version
duttonw
requested review from
ThrawnCA,
chris-randall-qol and
RossWebsterWork
ThrawnCA
reviewed
Dec 1, 2022
scripts/build.sh
Outdated
| echo "pip install -e git+https://github.com/${CKAN_GIT_ORG}/ckan.git@${CKAN_GIT_VERSION}#egg=ckan" | ||
| echo "do manually as its already a git pip installed module" | ||
| sudo git config --global --add safe.directory "$SRC_DIR/ckan" | ||
| #sudo pip install -e git+https://github.com/${CKAN_GIT_ORG}/ckan.git@${CKAN_GIT_VERSION}#egg=ckan |
There was a problem hiding this comment.
This line isn't really needed, along with the associated echo.
scripts/build.sh
Outdated
| pip install -r dev-requirements.txt | ||
| pip install -e . | ||
| # Replace default path to CKAN core config file with the one on the container | ||
| sed -i -e 's/use = config:.*/use = config:\/srv\/app\/src\/ckan\/test-core.ini/' test.ini |
There was a problem hiding this comment.
With a different separator eg |, and double quotes instead of single, this could make use of $APP_DIR.
ThrawnCA
approved these changes
Dec 1, 2022
ThrawnCA
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow our custom ckan version be tested against (which includes the iUploader changes to centralize download of files vs having it in a controller we need to override)