Qol 8600 new create a video embed component on swe #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew_Create_a_Video_embed_component_on_SWE # Conflicts: # src/template-pages/aggregation-page.html
ThrawnCA
approved these changes
Mar 21, 2022
devonpis
reviewed
Mar 21, 2022
ThrawnCA
approved these changes
Mar 22, 2022
|
That just needs a video URL and that should work with any provider. I am trying to find a video I can put as an example there
I think the component will work with any video provider because HTML just needs the video URL, I will both the examples. |
The example is generic , the component should work with any video URL. I tried Vimeo and it is working https://qld-gov-au.github.io/qg-web-template/components/video.html |
it would be nice to include the URLs (eg.https://player.vimeo.com/video/686195960?h=4c9609f09c&badge=0 for vimeo and https://www.youtube.com/embed/NpmB80pWUsk?rel=0 for youtube) in the component description so the user will expect what to pass to the |
devonpis
approved these changes
Mar 22, 2022
asifaminb
added a commit
that referenced
this pull request
May 5, 2022
* QOL-7764 Add disabled state to default and themed radio buttons / checkboxes (#374) * QOL-7764 disabled state added to default and themed radio buttons and checkboxes * QOL-7764 Changed some colours to use variables * QOL-7980 Transfer qg print from Matrix Assets to SWE4 (#376) * QOL-7980 Transfer qg print from Matrix Assets to SWE4 * updated FAQ * Added description and example markup for tables (#373) * QOL-8453 Update SWE FontAwesome <i> to <span> tags (#391) * QOL-8453 updated all fontawesome icon instances to use the sematically correct span tag, instead of i * QOL-8453 fixed find and replace error * updated readme * updated readme * updated readme * Qol 8391 form io style in swe (#393) * added forms.io styles * added forms.io styles * removed redundant versions * DC-26939-hashTrigger-function-fix (#379) * DC-26939-hashTrigger-function-fix * Added accordion-test.js * Added accordion-test.js * headless false * updated test * Qol 8453 reinstate back compatibility (#394) * reinstate style for fa using i and add warning * update msg * Dc 26939 accordion hashtrigger ix (#395) * DC-26939-hashTrigger-function-fix * Added accordion-test.js * Added accordion-test.js * headless false * updated test * added id match as well * added id match as well * check to run only one hash check (#396) * check to run only one hash check * removed console log * Qol 8453 add tests on alert and call out box (#399) * fix warning on vscode eslint plugin * add tests and stories in doc * nowrap any telephone numbers (#398) * Qol 8453 add tests on alert and call out box (#400) * fix warning on vscode eslint plugin * add tests and stories in doc * update qg-misc * update setTimeout * add comment * update timeout * update timeout * update test * DC-28049 Community Support Franchise (https://www.qld.gov.au/communit… (#401) * DC-28049 Community Support Franchise (https://www.qld.gov.au/community) broken hyperlink * transferred to 'head assets template' * Updated doc (#402) * Updated doc * Updated doc * QOL-8448 Updated facebook SDK version * transferred forms.io styles migration to the next release * DC-26939 - hashTrigger function fix and added test * QOL-7980 - Transfer qg print from Matrix Assets to SWE4 * QOL-8446 Update broken link in SWE template * QOL-7980-Transfer qg print from Matrix Assets to SWE4 * featured box link colour fix * release-v4.0.11-Hotfix * added timeout in 'quick exit test' * Qol 8396 UI design for image zoom on click for swe 4 (#410) * QOL-8396 UI design for Image zoom on click for SWE 4 * QOL-8396 UI design for Image zoom on click for SWE 4 and DC-28049 - change AGLS links * floating images * Added comments and styles changes * Added comments and styles changes * default color styles * refactor image figure Co-authored-by: asifamingov <[email protected]> * rename class for backward compatibility (#412) * Dc 96239 hash on links (#403) * check to run only one hash check * removed console log * updated function * updated function * fix qg-location (#422) * update style (#423) * update style (#425) * QOL-8616 fix unexpected alignment issue (#424) * update style * update test timeout * update version * update style (#426) * Added 'tech in use' section (#433) * QOL-8320-content-Alert-class-styles (#435) * update image icon style (#441) * Removed unused files (#440) * bower and jinja files not in use anymore * bower and jinja files not in use anymore * Qol 8600 new create a video embed component on swe (#442) * Added 'tech in use' section * QOL-8676 Improvement: Documentation for the 'promotional banner' component * QOL-8600 -New: Create a Video embed component on SWE * QOL-8600 -New: Create a Video embed component on SWE * Qol 8391 forms styles global (#439) * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391-added class .qg-forms-v2, #formio * updated css * Qol 8398 new add recpatcha in swe components doc (#445) * QOL-8398 Add recpatcha in SWE components doc * QOL-8398 Add recpatcha in SWE components doc * QOL-8398 Add recpatcha in SWE components doc * QOL-8398 Add recpatcha in SWE components doc * QOL-8398 updated HTML * QOL-8398 updated HTML * QOL-8391 - Form io style styles in SWE doc (#446) * update image icon style (#447) * promotional banner update * Qol 8600 new create a video embed component on swe (#448) * Added 'tech in use' section * QOL-8676 Improvement: Documentation for the 'promotional banner' component * QOL-8600 -New: Create a Video embed component on SWE * QOL-8600 -New: Create a Video embed component on SWE * QOL-8600-added vimeo example * Qol 8391 styles update (#451) * styles update * styles update * styles update * changed to rem * Qol 8468 move aside style from matrix assets to swe (#452) * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391-added class .qg-forms-v2, #formio * updated css * QOL-8468 Improvement: Move aside style from matrix-assets github repo to SWE * styles update * styles update * styles update * reverted the bg colour and removed the example template from pages * Qol 8391 styles update (#454) * styles update * styles update * styles update * changed to rem * added on focus styles * Qol 8391 styles update (#455) * styles update * styles update * styles update * changed to rem * added on focus styles * checkbox input styles update * Qol 8468 move aside style from matrix assets to swe (#456) * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391-added class .qg-forms-v2, #formio * updated css * QOL-8468 Improvement: Move aside style from matrix-assets github repo to SWE * styles update * styles update * styles update * reverted the bg colour and removed the example template from pages * removed the style to make all img 100% in aside * QOL-8600 New: Create a Video embed component on SWE * Dc 30133 swe feedback form new forms styles (#457) * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391 Improvement: Form io style - update style of forms on SWE and UI ki * QOL-8391-added class .qg-forms-v2, #formio * updated css * QOL-8468 Improvement: Move aside style from matrix-assets github repo to SWE * styles update * styles update * styles update * reverted the bg colour and removed the example template from pages * removed the style to make all img 100% in aside * QOL-8600 New: Create a Video embed component on SWE * DC-30133 - SWE Feedback form is not rendering radio buttons properly * Updated recaptcha doc * Updated recaptcha doc * DC-30133 SWE Feedback form is not rendering radio buttons properly * DC-30133 SWE Feedback form is not rendering radio buttons properly * DC-30133 styles update * updated jquery selector * updated styles * cleaned * DC-30133 SWE Feedback form is not rendering radio buttons properly * DC-30133 SWE Feedback form is not rendering radio buttons properly * DC-30133 SWE Feedback form is not rendering radio buttons properly * removed extra margin * added link * added link * updated doc * added margin for alerts * fixed html * QOL-8798 (#460) * QOL-8798 Form.io radio button styling issue * QOL-8798 Form.io radio button styling issue Co-authored-by: Rebecca Launder <[email protected]> Co-authored-by: devonpis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.