QOLDEV-34 QOLDEV-44 clean up link active states #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Dec 13, 2022
ThrawnCA
commented
- Apply underline rules to active/focus as well as hover
- Fix incorrect colouring of active banner links
- Refactor to extract more repeated behaviours to mix-ins
- drop unused secondary button dashed border that doesn't match documentation - extract repeated style rules to mixins - move link-related mixins to link file - extend underline-on-hover for links to include 'active' and 'focus' states - drop incorrect colouring on banner links, which would turn them from white to black on focus, and add example to Storybook
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
RossWebsterWork
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.