QOLDEV-245 fix Digital Dashboard links #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Jan 30, 2023
ThrawnCA
commented
- Don't apply 'inline-block' styling to the Digital Dashboard graph headings since it interferes with existing 'block' styling
- Make 'More Information' links consistently white
- This is needed for the Digital Dashboard, which wants to use 'display: block' styling within links. Setting inline-block disrupts it.
- Buttons should choose their own colour based on background colour
ThrawnCA
requested review from
chris-randall-qol,
duttonw,
kundupz and
RossWebsterWork
|
The changes seem good, although I can't seem to find a graph link example in the storybook to view. |
RossWebsterWork
approved these changes
Jan 31, 2023
|
@RossWebsterWork Yeah, the 'graph' class is used by the Digital Dashboard. Not ideal to update it here, but it is theoretically something that might be reused, and any graph is likely to have numbers rather than text. I couldn't find a good way to put spaces between the buttons without drastically reworking the page, so I left it as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.