QOLDEV-62 improve radio/checkbox styling #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Feb 3, 2023
ThrawnCA
commented
- Adjust border colour to match other form elements
- Add shadow on hover
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
- Was using #818181 in some places and #808080 in others. #808080 is defined as a variable and better matches Figma designs.
- Keep radio/checkbox position as 'static' even if wrapped in 'questions' and 'choices' elements
|
Disabled checkboxes and radio buttons have a light grey background colour in Figma which isn't present here, and the hover box seems a pixel larger than in Figma, otherwise it looks good |
RossWebsterWork
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.