QOLDEV-260 heading line height fix - h2 only #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
reviewed
Feb 19, 2023
| h2 { | ||
| line-height: 1.5em; | ||
| h2, h3, h4 { | ||
| line-height: 1.4; |
There was a problem hiding this comment.
Units have been dropped, did you mean 1.4em?
There was a problem hiding this comment.
Heading line-height values in SWE's underlying Bootstrap framework are unitless. Reading about line-height on Mozilla's developer documentation it says "The used value is the unitless number multiplied by the element's own font size. In most cases, this is the preferred way to set line-height and avoid unexpected results due to inheritance." I made the call to keep SWE's values unitless as well.
ThrawnCA
approved these changes
Feb 19, 2023
|
There is a conflict; you may need to merge the 4.0.15 branch into the QOLDEV-260 one, or rebase it. |
ThrawnCA
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed that for any h2 heading links in an aside that the underline weight change on hover was not entirely visible. Increasing h2 line-height to 1.4 addressed the problem.
Edit: Here's a screenshot example of what was happening:
