Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latam spanish keyboard layout #1324

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Add latam spanish keyboard layout #1324

merged 7 commits into from
Mar 25, 2024

Conversation

JuanoD
Copy link
Contributor

@JuanoD JuanoD commented Nov 23, 2023

Latin america uses a different keyboard from Spain. It makes it really hard to configure a keyboard.

Description

Added spanish (latam) layout.
Changed keys font to monospace to handle keys with AltGr modifiers correctly.

image
image

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding header file does not exist in the qmk_firmware repository. You need to open a PR there first.

@JuanoD
Copy link
Contributor Author

JuanoD commented Nov 25, 2023

Here is the PR to qmk_firmware qmk/qmk_firmware#22542

@JuanoD JuanoD requested a review from fauxpark December 4, 2023 02:27
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the font changes.

src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
@JuanoD JuanoD requested a review from fauxpark December 10, 2023 01:14
@JuanoD
Copy link
Contributor Author

JuanoD commented Mar 19, 2024

Is there anything stopping this from being merged?
My commit for the firmware headers is already merged into main.
If any other changes are needed, let me know.

@yanfali
Copy link
Collaborator

yanfali commented Mar 20, 2024

This looks pretty good, but I'm hardly an expert. @precondition any objections?

Copy link
Contributor

@precondition precondition left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the output of node qmk_configurator/src/i18n/keymap_extras/convert_keymap_extras_header.js qmk_firmware/quantum/keymap_extras/keymap_spanish_latin_america.h and the suggested file qmk_configurator/src/i18n/keymap_extras/keymap_spanish_latin_america.js unearthed multiple inconsistencies between what is said in the keymap header in QMK firmware repository and what is shown here.

I'm getting the sense you manually edited the pre-existing file for the Spanish host OS layout, but the intended, albeit undocumented, workflow is to run the convert_keymap_extras_header.js on a keymap_extras header file from qmk_firmware.

src/i18n/fr.csv Outdated Show resolved Hide resolved
src/i18n/ja.csv Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/ru.csv Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
@yanfali
Copy link
Collaborator

yanfali commented Mar 24, 2024

Thank you so much @precondition I have no objections to this being merged. @noroadsleft please merge if you have no objections

Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@yanfali
Copy link
Collaborator

yanfali commented Mar 24, 2024

@fauxpark either dismiss your review or approve. Thanks

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing...

src/i18n/keymap_extras/keymap_spanish_latin_america.js Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 304851f into qmk:master Mar 25, 2024
2 checks passed
@noroadsleft
Copy link
Member

¡Gracias por tu contribución! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants