-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latam spanish keyboard layout #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding header file does not exist in the qmk_firmware repository. You need to open a PR there first.
Here is the PR to qmk_firmware qmk/qmk_firmware#22542 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the font changes.
Is there anything stopping this from being merged? |
This looks pretty good, but I'm hardly an expert. @precondition any objections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing the output of node qmk_configurator/src/i18n/keymap_extras/convert_keymap_extras_header.js qmk_firmware/quantum/keymap_extras/keymap_spanish_latin_america.h
and the suggested file qmk_configurator/src/i18n/keymap_extras/keymap_spanish_latin_america.js
unearthed multiple inconsistencies between what is said in the keymap header in QMK firmware repository and what is shown here.
I'm getting the sense you manually edited the pre-existing file for the Spanish host OS layout, but the intended, albeit undocumented, workflow is to run the convert_keymap_extras_header.js
on a keymap_extras header file from qmk_firmware.
Thank you so much @precondition I have no objections to this being merged. @noroadsleft please merge if you have no objections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
@fauxpark either dismiss your review or approve. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing...
¡Gracias por tu contribución! 😄 |
Latin america uses a different keyboard from Spain. It makes it really hard to configure a keyboard.
Description
Added spanish (latam) layout.
Changed keys font to monospace to handle keys with AltGr modifiers correctly.