Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Breeze Rev1 default #878

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

eithanshavit
Copy link
Contributor

Description

Adding a new default keymap for Breeze Rev1.
Also, matching the Rev0 keymap with the commit hash state.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also note that you have the LOWER/MO(1) and RAISE/MO(2) keycodes in opposite order from how they are on qmk/qmk_firmware, but the qmk_firmware keymap should be updated to match this behaviour IMO, because the RAISE keycode actually blocks access to KC_P0 on that side anyway.

public/keymaps/a/afternoonlabs_breeze_rev1_default.json Outdated Show resolved Hide resolved
@eithanshavit
Copy link
Contributor Author

Thanks @noroadsleft, I've committed the new hash.
Also, thanks for the catch on the MO order, it makes sense to update qmk_firmware. I'll do it in a separate PR.

@eithanshavit
Copy link
Contributor Author

Updated qmk_firmware to match in qmk/qmk_firmware#11779

@noroadsleft noroadsleft merged commit 8a7dca4 into qmk:master Feb 3, 2021
@noroadsleft
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants