Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergodox Infinity LED matrix handling #1077

Closed
yiancar opened this issue Feb 9, 2017 · 8 comments
Closed

Ergodox Infinity LED matrix handling #1077

yiancar opened this issue Feb 9, 2017 · 8 comments
Assignees

Comments

@yiancar
Copy link
Contributor

yiancar commented Feb 9, 2017

Not an issue but rather a question. I was looking to in the Ergodox Infinity files to try to determine how you control the LED matrix (IS31FL3731C) where exactly is that located as I couldnt find it?

@SjB
Copy link
Contributor

SjB commented Feb 13, 2017

I was told that the visualiser will be changing but for now you could look at my keymap at https://github.com/SjB/qmk_firmware/tree/sjb-keymaps/keyboards/ergodox/keymaps/sjb

@fredizzimo
Copy link
Contributor

I will soon enable the old visualizer from my TMK fork, which should have LED support. It's quite untested and possibly with some issue as reported [https://github.com/fredizzimo/infinity_ergodox/issues/5]

The reason why it wasn't done, was that I wanted to do a bigger effect system. However for many reasons it's taken a very long time, and it still doesn't seem to be very near. So better make something that works first.

@fredizzimo
Copy link
Contributor

The LCD and visualizer support is now merged. But the LEDs are currently disabled and there's no animation that would use them. I believe the underlying code works though.

As I don't have LEDs installed myself, it would be good if someone else test the code and complete the support by adding it to both the keyboard default visualizer and the simple_visualizer, in a suitable way. But first it's probably worth testing the test animation that is included in the animations.c file.

Unfortunately there's no documentation for this yet, except for some code comments, the test animation and the two visualizers (infinity/visualizer.c and infinity/simple_visualizer.h ) included. But it shouldn't be too hard to figure out if you are an experienced enough coder. Some of the code comments might have been deleted because of restructuring, so it might be worthwhile to check the old documented code as well

One thing to note is that the LEDs are exposed as an uGFX display in gray color, so it supports controlling individual LEDs by plotting "pixel", but also more high level things like lines and circles, and even text.

@fredizzimo
Copy link
Contributor

Has anyone been able to test the LED support, does it work and can the issue be closed?

@packman86
Copy link

I am also very interested in getting my backlighting to work on my Ergodox Infinity with QMK.

@fredizzimo
Copy link
Contributor

I have the emulator in good enough shape now, that I could implement some basic backlight support, but I can't say when it will be done.

That would be enabled by BACKLIGHT_ENABLE, and just lit up all the LEDs, allowing for the normal QMK brightness controls.

When the keyboard goes to sleep, I will just disable the backlight.

If someone else is willing to work on that, please inform me before you start, so that I know.

@fredizzimo
Copy link
Contributor

I have now made some initial support in #1361. It's not tested yet, so testers are welcome to try it out.

@fredizzimo fredizzimo self-assigned this Jun 3, 2017
@fredizzimo
Copy link
Contributor

Basic LED support have now been merged in, so closing this.

mattpcaswell pushed a commit to mattpcaswell/qmk_firmware that referenced this issue Jun 7, 2023
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants