Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Japanese translation of feature_unicode.md #10985

Merged
merged 6 commits into from
Feb 14, 2021
Merged

[Docs] Japanese translation of feature_unicode.md #10985

merged 6 commits into from
Feb 14, 2021

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Nov 20, 2020

Description

Add Japanese translation of docs/feature_unicode.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Nov 20, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

s-show
s-show reviewed Nov 26, 2020
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Nov 26, 2020
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Nov 26, 2020
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Nov 26, 2020
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Nov 26, 2020
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Nov 26, 2020
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
shelaf
shelaf reviewed Jan 6, 2021
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
mtei
mtei reviewed Feb 6, 2021
View reviewed changes
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
docs/ja/feature_unicode.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team February 7, 2021 21:27
@mtei mtei requested a review from a team February 7, 2021 21:42
@mtei
Copy link
Contributor

mtei commented Feb 7, 2021

I think this is ready to merge.

@mtei mtei merged commit 50d816f into qmk:master Feb 14, 2021
@mtei
Copy link
Contributor

mtei commented Feb 14, 2021

Thank you!

@umi-umi umi-umi deleted the feature_unicode.md-japanese-translation branch March 21, 2021 01:13
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@umi-umi
[Docs] Japanese translation of feature_unicode.md (qmk#10985)
dff3c5e 
* add feature_unicode.md translation

* consolidate sentence end

* update based on comment

* update based on comment

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shelaf shelaf shelaf approved these changes

@mtei mtei mtei approved these changes

@s-show s-show s-show approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umi-umi @mtei @shelaf @s-show