Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eggman keyboard #11701

Merged
merged 9 commits into from
Feb 18, 2021
Merged

add eggman keyboard #11701

merged 9 commits into from
Feb 18, 2021

Conversation

qpockets
Copy link

add new keyboard "eggman" to qmk master.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 12, 2021 22:51
spidey3
spidey3 requested changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please fix the copyright notices to list real name (a person or legal business entity).

keyboards/eggman/config.h Outdated Show resolved Hide resolved
keyboards/eggman/eggman.c Outdated Show resolved Hide resolved
keyboards/eggman/eggman.h Outdated Show resolved Hide resolved
keyboards/eggman/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/eggman/keymaps/default/keymap.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Feb 14, 2021
View reviewed changes
keyboards/eggman/readme.md Outdated Show resolved Hide resolved
qpockets and others added 5 commits February 15, 2021 09:18
@qpockets
Update eggman.h
a9a9850 
correct copyright info
@qpockets
Update eggman.c
dab98ce 
correct copyright info
@qpockets
Update config.h
5222204 
correct copyright info
@qpockets
Update keymap.c
4dad0e5 
correct copyright info
@qpockets @fauxpark
Update keyboards/eggman/readme.md
890b3be 
reduce image size

Co-authored-by: Ryan <[email protected]>
spidey3
spidey3 requested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but there's one place where you missed fixing the copyright.

keyboards/eggman/keymaps/default/config.h Outdated Show resolved Hide resolved
@qpockets @spidey3
Update keyboards/eggman/keymaps/default/config.h
7ff664c 
correct copyright

Co-authored-by: Joshua Diamond <[email protected]>
spidey3
spidey3 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spidey3 spidey3 merged commit 890f3a5 into qmk:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@spidey3 spidey3 spidey3 approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qpockets @drashna @fauxpark @spidey3