Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Noxary 268.2 RGB #11772

Merged
merged 15 commits into from
Feb 16, 2021
Merged

Add Noxary 268.2 RGB #11772

merged 15 commits into from
Feb 16, 2021

Conversation

Rozakiin
Copy link
Contributor

@Rozakiin Rozakiin commented Feb 2, 2021

Description

Add Noxary 268.2 RGB firmware, default and VIA.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Rozakiin Rozakiin changed the title 268.2 rgb Add Noxary 268.2 RGB Feb 2, 2021
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 2, 2021
@Rozakiin Rozakiin mentioned this pull request Feb 2, 2021
Merged
6 tasks
drashna
drashna requested changes Feb 5, 2021
View reviewed changes
keyboards/noxary/268_2_RGB/268_2_RGB.c Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/config.h Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team February 5, 2021 06:57
fauxpark
fauxpark requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename all of these files to lowercase.

keyboards/noxary/268_2_RGB/rules.mk Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/rules.mk Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/readme.md Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/noxary/268_2_RGB/config.h Outdated Show resolved Hide resolved
Rozakiin and others added 7 commits February 8, 2021 09:22
@drashna
Copy link
Member

drashna commented Feb 16, 2021

Thanks!

@drashna drashna merged commit 2d55f34 into qmk:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rozakiin @drashna @fauxpark