Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DimplePlus 7u Layout #11816

Merged
merged 2 commits into from
Feb 21, 2021
Merged

Add DimplePlus 7u Layout #11816

merged 2 commits into from
Feb 21, 2021

Conversation

jbaskeen
Copy link

@jbaskeen jbaskeen commented Feb 7, 2021

Description

This change introduces the 7u layout option with 2.25 enter key and 2.0 BS key to qmk for the DimplePlus keyboard. Since this layout was being added, I also updated the existing layout's layout spacing in an attempt to improve readability.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

No/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jbaskeen
Copy link
Author

jbaskeen commented Feb 7, 2021

@jackytrabbit FYI in case I did anything inappropriate here. This is my first qmk contribution so I'm not confident I put it together correctly for D+.

@jbaskeen
Copy link
Author

@zvecr any other feedback to get this wrapped up?

@drashna drashna requested a review from a team February 19, 2021 03:33
@jbaskeen jbaskeen requested a review from zvecr February 20, 2021 11:49
@drashna
Copy link
Member

drashna commented Feb 21, 2021

Thanks!

@drashna drashna merged commit 03679f0 into qmk:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants