Move mousekey keycodes into newly freed up keycode block #16076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
force-pushed
the
core/move_mousekey_value
branch
from
be9fd55
to
bee43ca
Compare
drashna
force-pushed
the
core/move_mousekey_value
branch
from
07f9c5c
to
96ea13c
Compare
drashna
force-pushed
the
core/move_mousekey_value
branch
from
96ea13c
to
7228fc0
Compare
drashna
force-pushed
the
core/move_mousekey_value
branch
from
7228fc0
to
b5ef593
Compare
drashna
force-pushed
the
core/move_mousekey_value
branch
from
b5ef593
to
aba0df4
Compare
noroadsleft
approved these changes
Jul 18, 2022
The reason for this move is because ACTION LAYER reserves 0xE0-0xFF for internal usage. Namely, for other layer functions. This means that LT is limited to 0x00-0xDF keycodes, and effectively blocks mousekeys from being used. By moving the mousekeys, this allows them to be used as part of LT.
drashna
force-pushed
the
core/move_mousekey_value
branch
from
aba0df4
to
21a7c4d
Compare
8 tasks
tzarc
approved these changes
Sep 17, 2022
|
Does this mean with |
That's explicitly what it means! |
17 tasks
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason for this move is because ACTION LAYER reserves 0xE0-0xFF for internal usage.
Namely, for other layer functions. This means that LT is limited to 0x00-0xDF keycodes,
and effectively blocks mousekeys from being used.
By moving the mousekeys, this allows them to be used as part of LT.
This leaves C0-CC usable, still.
Types of Changes
Checklist