Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform stricter lint checks #17094

Closed
wants to merge 3 commits into from
Closed

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 14, 2022

Description

Adds checks for:

  • files that have bypassed .gitignore
    • Makefile files inside keyboard folder
    • via*.json files
  • ensure default keymap exists

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added CI cli qmk cli command python labels May 14, 2022
@zvecr zvecr changed the base branch from develop to master May 31, 2022 14:54
@drashna drashna requested a review from a team June 2, 2022 17:18
@github-actions github-actions bot added core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support and removed CI labels Jun 9, 2022
@github-actions github-actions bot removed keymap translation documentation via Adds via keymap and/or updates keyboard for via support core keyboard labels Jun 9, 2022
@zvecr zvecr marked this pull request as ready for review June 9, 2022 20:11
@zvecr zvecr marked this pull request as draft June 10, 2022 01:58
@zvecr zvecr marked this pull request as ready for review June 10, 2022 03:46
@zvecr zvecr marked this pull request as draft June 10, 2022 04:13
@zvecr zvecr marked this pull request as ready for review June 10, 2022 08:07
@zvecr zvecr closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant