Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Split] pointing transport check #17481

Merged
merged 1 commit into from
Jun 26, 2022
Merged

[Split] pointing transport check #17481

merged 1 commit into from
Jun 26, 2022

Conversation

Kriechi
Copy link
Contributor

@Kriechi Kriechi commented Jun 26, 2022

Description

This PR reduces user confusion when using POINTING_DEVICE_{LEFT,RIGHT,COMBINED} while not having SPLIT_POINTING_ENABLE defined as well. Previously it would just silently fail and cause the other half to crash/not connect.

In the same spirit as #17466.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    • qmk multibuild -f SPLIT_KEYBOARD=yes came back with no errors

@github-actions github-actions bot added the core label Jun 26, 2022
KarlK90
KarlK90 approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KarlK90 KarlK90 requested a review from a team June 26, 2022 15:50
@drashna drashna merged commit 0d013a2 into qmk:develop Jun 26, 2022
@Kriechi Kriechi deleted the split-pointing-transport-check branch June 26, 2022 16:23
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Kriechi @zykrah
[Split] Verify Split Pointing Device config (qmk#17481)
509edc3
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Kriechi @nolanseaton
[Split] Verify Split Pointing Device config (qmk#17481)
d2eec3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kriechi @drashna @KarlK90