Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] PMW33XX drivers overhaul #17613

Merged
merged 2 commits into from
Jul 14, 2022
Merged

[Core] PMW33XX drivers overhaul #17613

merged 2 commits into from
Jul 14, 2022

Commits on Jul 14, 2022

  1. PMW33XX drivers overhaul 

    This combines the PMW3389 and PM3360 drivers as they only differ in the
firmware blobs and CPI get and set functions. The following changes have
been made:

* PMW3389 now gets the same multi-sensor feature that is already available on the
  PMW3360.

* Introduced a shared pmw33xx_report_t struct is now directly readable via SPI
  transactions instead of individual byte-sized reads, saving multiple
  copies and bitshift operations.

* pmw33(89/60)_get_report functions had unreachable branches in their motion
  detection logic these have been simplied as much as possible.

* The fast firmware upload option has been removed as this becomes obsolete by
  the newly introduced polled waiting functions for ChibiOS

* PMW33(60/89)_SPI_LSBFIRST and PMW33(60/89)_SPI_MODE config options
  have been removed as they don't need to be configurable.

* All PMW3389 and PMW3360 defines have been unified to a PMW33XX prefix
  to reduce code duplication and make the defines interchangeable

polled waiting
    @KarlK90
    KarlK90 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    b93b1a9 View commit details
    Browse the repository at this point in the history

  2. Adjust keyboards to PMW33XX naming scheme

    @KarlK90
    KarlK90 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    4aa2c5a View commit details
    Browse the repository at this point in the history