Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elite-C to converters #18309

Merged
merged 4 commits into from
Sep 18, 2022
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 7, 2022

Description

#18239 broke conversions which incorrectly relied on Elite-C pinouts for Pro Micro converters.

Future iteration

Potentially reduce duplication by inferring promicro compatibility when targeting elite_c.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

docs/feature_converters.md Outdated Show resolved Hide resolved
docs/feature_converters.md Outdated Show resolved Hide resolved
docs/feature_converters.md Outdated Show resolved Hide resolved
@zvecr zvecr changed the base branch from master to develop September 8, 2022 17:48
@zvecr zvecr force-pushed the feature/elite_c_to_stemcell branch from 1b1c3ed to 42deeb8 Compare September 8, 2022 19:16
@zvecr zvecr requested a review from a team September 8, 2022 19:18
@zvecr zvecr changed the title Add Elite-C to STeMCell converter Add Elite-C to converters Sep 8, 2022
@tzarc tzarc requested review from fauxpark and a team September 17, 2022 04:58
@zvecr zvecr merged commit 1155140 into qmk:develop Sep 18, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
#define B5 9U

// Right side (front)
// RAW
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not RAW on Elite-C, it is B0. Can B0 be mapped to 10U or 11U so that the converter can at least succeed on boards that use B0 on Elite-C? Even if it means the user has to jump the pin...

#define B5 PAL_LINE(GPIOB, 9)

// Right side (front)
// RAW
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the same issue here. This is not RAW on Elite-C. The converter will not succeed on boards that use B0

| Pinout | Notes |
|------------|-----------------------------------|
| `promicro` | Includes RX/TX LEDs |
| `elite_c` | Includes bottom row pins, no LEDs |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also include B0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants