dygma/raise: multiple fixes and improvements #18361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- respect RGB_MATRIX_ENABLE = no
- Only flush LED buffer when changes have occurred. This significantly
improves typing accuracy by reducing traffic related to LED state,
increasing the bandwidth available for matrix scans.
- improve configurability of RGB matrix, reduce refresh rate
- Reduce LED refresh rate from 60fps to 10fps, given the significant
impact on typing accuract.
- Allow enabling/disabling of reactive RGB matrix modes from rules.mk
- fix right-hand ansi LED key map
- The ansi layout right hand LED key mapping was seemingly flipped and
offset by 1 key. For example, when the LED for "7" was to light, the
"= +" LED would light, instead. Reversing each row of the led mapping
resolved the issue.
- LEDs for the "\ |" and "enter" keys were swapped.
- fix color order to GRB
- Colors were incorrectly mapped with red and green swapped. Actual
color order is GRB, not RGB.
- Add color-correction for red channel, as it apparently receives more
voltage than the other color channels.
|
@ibash you might be interested in this |
|
Awesome! Lgtm Out of curiosity what are you using for a mcu? |
Some random black pill clone I picked up off of amazon. |
drashna
approved these changes
Sep 14, 2022
fauxpark
requested changes
Sep 14, 2022
- Fix iso LED mapping (matches ansi) - Fix g_led_config parsing complaints. Parser does not like non-numeric values.
- Eliminate ifdefs for RGB_MATRIX_ENABLE. - add post_rules.mk to handle addition of leds.c sources when RGB_MATRIX_ENABLE is yes.
justfalter
requested review from
drashna and
fauxpark
and removed request for
fauxpark and
drashna
|
@justfalter thanks for all the work here! Hopefully this can get a second approval soon... |
ibash
approved these changes
Sep 28, 2022
fauxpark
approved these changes
Sep 28, 2022
justfalter
referenced
this pull request
in ibash/qmk_firmware
Sep 29, 2022
Adds stm32 eeprom emulation for stm32F4 mcus. Specifically this: 1. Adds the stm32f4 flash hals. 2. Adds an eeprom shim to match the avr library. 3. Sets a custom memory map so that the first sector is used for the vector table, the next two sectors are used for eeprom emulation, and finally the rest is used for code. We do this because the first four sectors are 16kb, and the rest are much larger. If we used a larger sector for eeprom emulation it would be slower and more wasteful. 4. Adds via json for the dygma raise Left to do: Make this play well with the preexisting eeprom library. It'd be best to move them all into eeprom_stm32 and then change the filenames to be per mcu, and then selectively load them.
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Oct 2, 2022
aivalja
pushed a commit
to aivalja/qmk_firmware
that referenced
this pull request
Nov 7, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes multiple fixes and improvements to the dygma raise implementation. Much of this centered around improving the accuracy and performance of LED light handling.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist