Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback unrelated changes from previous PR. #19015

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Rollback unrelated changes from previous PR. #19015

merged 1 commit into from
Nov 9, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Nov 9, 2022

Description

These came in through #18829 despite being unrelated. Causes conflicts with other in-flight PRs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team November 9, 2022 20:40
@tzarc tzarc added the bug label Nov 9, 2022
@tzarc tzarc merged commit 575b0e3 into qmk:develop Nov 9, 2022
@tzarc tzarc deleted the rollback-unrelated branch November 9, 2022 20:43
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
Rollback unrelated changes from previous PR. (qmk#19015)
373671e
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@tzarc @elpekenin
Rollback unrelated changes from previous PR. (qmk#19015)
5a67340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @zvecr