Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default limit to OLED dirty processing #19068

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Add default limit to OLED dirty processing #19068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0de7294
Add default limit to OLED dirty processing
zvecr Nov 13, 2022
bed1444
update comment
zvecr Nov 13, 2022
7ca689b
rename var
zvecr Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/oled/oled_driver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
# define OLED_UPDATE_INTERVAL 50
#endif

#if !defined(OLED_UPDATE_PROCESS_LIMIT)
# define OLED_UPDATE_PROCESS_LIMIT 1
#endif

typedef struct __attribute__((__packed__)) {
uint8_t *current_element;
uint16_t remaining_element_count;
Expand Down
5 changes: 3 additions & 2 deletions drivers/oled/ssd1306_sh1106.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,9 @@ void oled_render(void) {
// Turn on display if it is off
oled_on();

uint8_t update_start = 0;
while (oled_dirty) { // render all dirty blocks
uint8_t update_start = 0;
uint8_t num_processed = 0;
while (oled_dirty && num_processed++ < OLED_UPDATE_PROCESS_LIMIT) { // render all dirty blocks (up to the configured limit)
// Find next dirty block
while (!(oled_dirty & ((OLED_BLOCK_TYPE)1 << update_start))) {
++update_start;
Expand Down