Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM #19335

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM #19335

merged 1 commit into from
Dec 15, 2022

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Dec 15, 2022

Description

Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (Issue #15345).
Also, a slight efficiency improvement.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@spidey3 spidey3 requested a review from drashna December 15, 2022 01:50
@github-actions github-actions bot added the core label Dec 15, 2022
drashna
drashna approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this work on AVR and ARM. Yay!

@drashna
Copy link
Member

drashna commented Dec 15, 2022

@yiancar

@drashna drashna requested a review from a team December 15, 2022 07:07
@drashna drashna added the bug label Dec 15, 2022
@drashna drashna merged commit 571a979 into qmk:master Dec 15, 2022
@yiancar
Copy link
Contributor

yiancar commented Dec 15, 2022

Thank you :D

crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@spidey3 @crembz
Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (qmk#19335)
b422e89
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@spidey3
Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (qmk#19335)
841f037
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@spidey3 @omikronik
Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (qmk#19335)
4e19e3e
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@spidey3 @ideas32
Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (qmk#19335)
8a5fa0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spidey3 @drashna @yiancar @fauxpark