-
-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Add Arrow Mechanics WINGS #23227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied review suggestions, please see one comment
Co-authored-by: Joel Challis <[email protected]>
34a2115
to
18741b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied all review suggestions
No more functional changes in this PR! (just fixes if needed) |
Co-authored-by: Joel Challis <[email protected]>
I see, I'll stop and wait until You're ready :)
|
Is there anything else that stops us from merging? |
Also, this might be a thing for thought when it comes to maintenance rules of the QMK repo - how should I know as a minor contributor, how many updates to the main branch should I expect before my PR is taken care of? I understand my mistake now, but it's not that obvious in general for there are no releases, no time-related or anyhow strict rules of merging to main. It actually looks confusing as multiple minor updates were merged in the meantime without even passing the pipelines - maybe it's a good idea to elaborate on that in the docs? |
It's not obvious, because the vast majority of people aren't so eager to update their repo. I've disabled CI for your PR for now. If/when collabs get back to it, they can remove the label and retrigger CI on demand. |
Co-authored-by: Drashna Jaelre <[email protected]>
This PR seems to have too many comments/issues vs. few changes that it actually introduces. Closing to create a clean version since it may take too much time to dig into things that are already fixed. |
Description
Add base support for Arrow Mechanics WINGS keyboard with all the essential features
Types of Changes
Issues Fixed or Closed by This PR
Checklist