Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding recore keyboard #23320

Merged
merged 47 commits into from
Mar 29, 2024
Merged

Adding recore keyboard #23320

merged 47 commits into from
Mar 29, 2024

Conversation

joliverMI
Copy link
Contributor

@joliverMI joliverMI commented Mar 20, 2024 •
edited
Loading

-Added a new keyboard under PMK: recore

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

joliverMI and others added 30 commits March 11, 2024 16:19
Created posey_split keyboards and included default keymaps.
76dbc6a
@joliverMI @waffle87
Update keyboards/pmk/posey_split/posey_split_v4/config.h
bf006be 
Co-authored-by: jack <[email protected]>
@joliverMI @waffle87
Update keyboards/pmk/posey_split/posey_split_v4/config.h
046699f 
Co-authored-by: jack <[email protected]>
@joliverMI @waffle87
Update keyboards/pmk/posey_split/posey_split_v4/info.json
ebdd8a8 
Co-authored-by: jack <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/posey_split_v4/info.json
53d3c64 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/posey_split_v4/info.json
d2c693c 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @waffle87
Update keyboards/pmk/posey_split/posey_split_v4/readme.md
a18b87e 
Co-authored-by: jack <[email protected]>
@joliverMI
Merge branch 'master' into dev_branch
7db3bd9
Various cleanup updates per QMK maintainers on PR qmk#23258
70240c2
Merge branch 'dev_branch' of https://github.com/joliverMI/qmk_firmware …
a220bf0 
…into dev_branch
removed config files from via keymaps
4ffca2f
removed additional keyboard for PR.
c150aa6
changed folder structure per PR suggestion
58cbe1d
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v5/info.json
6340095 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v5/rules.mk
3957deb 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v4/rules.mk
358f39b 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v5/keymaps/VIA/keymap.c
24bff72 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v5/keymaps/default/keymap.c
7e513c8 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v4/keymaps/default/keymap.c
1cf7d57 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v4/keymaps/VIA/keymap.c
c902cfb 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v5/readme.md
87accce 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v4/readme.md
3226145 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v4/info.json
2879869 
Co-authored-by: Joel Challis <[email protected]>
changed via folders to lowercase
584a81b
cleaned up extra via files in wrong folder
c74b317
Added better descriptions to keyboard projects and added hardware lis…
3155019 
…ting to v5
Cleaned up keymap format
6728ca1
removed extra rules
a4e979d
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v4/keymaps/via/keymap.c
e22e04c 
Co-authored-by: Joel Challis <[email protected]>
@joliverMI @zvecr
Update keyboards/pmk/posey_split/v5/readme.md
6b67f10 
Co-authored-by: Joel Challis <[email protected]>
dunk2k
dunk2k suggested changes Mar 20, 2024
View reviewed changes
keyboards/pmk/recore/v3/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/pmk/recore/v3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/pmk/recore/v3/readme.md Outdated Show resolved Hide resolved
@joliverMI joliverMI requested a review from dunk2k March 21, 2024 12:13
dunk2k
dunk2k suggested changes Mar 21, 2024
View reviewed changes
keyboards/pmk/recore/v3/info.json Outdated Show resolved Hide resolved
@philvec philvec mentioned this pull request Mar 22, 2024
Merged
14 tasks
@drashna drashna merged commit 041f60f into qmk:master Mar 29, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@joliverMI @waffle87
@zvecr @dunk2k
[Keyboard] Add recore keyboard (qmk#23320)
a9fb7d5 
Co-authored-by: joliverMI <qmk@Desktop2023>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@joliverMI @waffle87
@zvecr @dunk2k @girtsf
[Keyboard] Add recore keyboard (qmk#23320)
8ac01a9 
Co-authored-by: joliverMI <qmk@Desktop2023>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@joliverMI @waffle87
@zvecr @dunk2k @whoisjordangarcia
[Keyboard] Add recore keyboard (qmk#23320)
98fd00c 
Co-authored-by: joliverMI <qmk@Desktop2023>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
@joliverMI joliverMI mentioned this pull request Aug 9, 2024
Open
8 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@joliverMI @waffle87
@zvecr @dunk2k @nuess0r
[Keyboard] Add recore keyboard (qmk#23320)
5ea6b7d 
Co-authored-by: joliverMI <qmk@Desktop2023>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joliverMI @drashna @waffle87 @dunk2k