Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new keyboard ThumbsUp! v9 with a default keymap #23800

Merged
merged 21 commits into from
Oct 6, 2024
Merged

Added a new keyboard ThumbsUp! v9 with a default keymap #23800

merged 21 commits into from
Oct 6, 2024

Conversation

ak66666
Copy link
Contributor

@ak66666 ak66666 commented May 26, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes May 26, 2024
View reviewed changes
keyboards/thumbsup/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/thumbsup/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/thumbsup/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/thumbsup/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/thumbsup/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/info.json Outdated Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/readme.md Outdated Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/readme.md Outdated Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/rules.mk Outdated Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/info.json Outdated Show resolved Hide resolved
ak66666 and others added 12 commits May 28, 2024 15:24
@ak66666 @waffle87
Update keyboards/thumbsup/keymaps/default/keymap.c
1a4db31 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/keymaps/default/keymap.c
4bb076e 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/keymaps/default/keymap.c
b023dbd 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/keymaps/default/keymap.c
d525cdf 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/keymaps/default/keymap.c
172a9b3 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/rev9_promicro_4x12/info.json
233538e 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/rev9_promicro_4x12/readme.md
71e737e 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/rev9_promicro_4x12/readme.md
a139c55 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/rev9_promicro_4x12/rules.mk
5d64881 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Update keyboards/thumbsup/rev9_promicro_4x12/info.json
4b5318a 
As per PR review suggestions.

Co-authored-by: jack <[email protected]>
@ak66666 @waffle87
Apply suggestions from code review
613bb3b 
Co-authored-by: jack <[email protected]>
@ak66666
Delete keyboards/thumbsup/keymaps/default/readme.md as per review rec…
a4beac2 
…ommendation.
ak66666
ak66666 commented May 28, 2024
View reviewed changes
Copy link
Contributor Author

@ak66666 ak66666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.
I accepted all the recommendations,

waffle87
waffle87 requested changes May 29, 2024
View reviewed changes
keyboards/thumbsup/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/thumbsup/keymaps/default/rules.mk Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/config.h Outdated Show resolved Hide resolved
keyboards/thumbsup/rev9_promicro_4x12/info.json Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team May 30, 2024 06:29
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 15, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 8, 2024
@tzarc tzarc merged commit 7446c6e into qmk:master Oct 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark left review comments

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ak66666 @drashna @fauxpark @waffle87 @tzarc