Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add keyboard Piantor UV 44 #24247

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[Keyboard] Add keyboard Piantor UV 44 #24247

wants to merge 15 commits into from
+167 −0

Conversation

azhizhinov
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 6, 2024
@azhizhinov
Copy link
Contributor Author

Hello. Changed to ImgBB, is that OK?

@waffle87 waffle87 requested a review from a team August 17, 2024 15:46
@drashna
Copy link
Member

drashna commented Aug 30, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Otherwise, LGTM.

drashna
drashna requested changes Aug 30, 2024
View reviewed changes
keyboards/piantoruv44/rules.mk Outdated Show resolved Hide resolved
keyboards/piantoruv44/keyboard.json Show resolved Hide resolved
@azhizhinov
Copy link
Contributor Author

@drashna
Hello.
Done.

@zvecr
Copy link
Member

zvecr commented Aug 30, 2024

Hello.
Done.

The following have not been completed.
#24247 (comment)
#24247 (comment)

@azhizhinov
Copy link
Contributor Author

@zvecr
Hello.
Done.

@zvecr
Copy link
Member

zvecr commented Aug 30, 2024 •
edited
Loading

#24247 (comment)

Done.

...nope

@azhizhinov
Copy link
Contributor Author

@zvecr
rules.mk has been deleted.

@azhizhinov
Copy link
Contributor Author

Hello.
@drashna, sorry to bother you, but could you review this PR?
Is anything there for me to improve?
Thanks in advance.

fauxpark
fauxpark requested changes Sep 29, 2024
View reviewed changes
keyboards/piantoruv44/keyboard.json Show resolved Hide resolved
keyboards/piantoruv44/readme.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azhizhinov @drashna @zvecr @fauxpark @waffle87