Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Skyloong GK980 backlight ANSI key layout Keyboard #24461

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NaturalZh
Copy link

Skyloong GK980 backlight ANSI key layout Keyboard

Description

Skyloong GK980 backlight keyboard with 4 interchangeable encoders. It`s ANSI key layout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87
Copy link
Member

waffle87 commented Oct 7, 2024

Can you please provide a link to where this hardware can be found, or some other form of verification that this is not a tri-mode/wireless keyboard? All references to "GK980" on the provided store page indicate that this is a wireless keyboard. The code in keyboards/skyloong/gk980/bl/bl.c is especially suspect.

@tzarc
Copy link
Member

tzarc commented Oct 7, 2024

Why did you re-raise after closing #23611?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants